Skip to content

Add class registering way of registering stuff#21

Open
Knerio wants to merge 1 commit intomainfrom
20-add-new-way-of-registering-functions
Open

Add class registering way of registering stuff#21
Knerio wants to merge 1 commit intomainfrom
20-add-new-way-of-registering-functions

Conversation

@Knerio
Copy link
Copy Markdown
Member

@Knerio Knerio commented Apr 7, 2026

close #20

@Knerio Knerio requested a review from nicosammito April 7, 2026 20:15
@Knerio Knerio self-assigned this Apr 7, 2026
return fibonacci(num - 1n) + fibonacci(num - 2n);
}
@Identifier("fib")
@Signature("(number: number) => number")
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The signature is wrong here and not valid.

Suggested change
@Signature("(number: number) => number")
@Signature("(number: number): number")

version: version || config.version,
runtimeName: identifier,
deprecationMessage: deprecationMessage || [],
displayIcon: displayIcon || "",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default should be null

Suggested change
displayIcon: displayIcon || "",
displayIcon: displayIcon || null,

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

GitLab Pipeline Action

General information

Link to pipeline: https://gitlab.com/code0-tech/development/hercules/-/pipelines/2435686688

Status: Passed
Duration: 1 minutes

Job summaries

docs:preview

Documentation preview available at https://code0-tech.gitlab.io/-/development/telescopium/-/jobs/13819119406/artifacts/out/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add new way of registering functions

2 participants